Skip to content

Make 'grace-web-mvc' decoupled from 'grace-web-sitemesh' #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rainboyan merged 1 commit into from
Dec 6, 2025
+0 −6
Merged

Make 'grace-web-mvc' decoupled from 'grace-web-sitemesh' #1247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion grace-web-mvc/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
dependencies {
api project(":grace-gsp")
api project(":grace-web")
api project(":grace-web-sitemesh")
api project(":grace-web-url-mappings")

compileOnlyApi libs.jakarta.servlet
Expand Down
5 changes: 0 additions & 5 deletions grace-web-mvc/src/main/groovy/org/grails/web/errors/GrailsExceptionResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
import org.grails.web.mapping.DefaultUrlMappingInfo;
import org.grails.web.mapping.UrlMappingUtils;
import org.grails.web.servlet.mvc.exceptions.GrailsMVCException;
import org.grails.web.sitemesh.GrailsContentBufferingResponse;
import org.grails.web.util.GrailsApplicationAttributes;
import org.grails.web.util.WebUtils;

Expand Down Expand Up @@ -195,10 +194,6 @@ protected ModelAndView resolveViewOrForward(Exception ex, UrlMappingsHolder urlM
else if (info != null && info.getControllerName() != null) {
String uri = determineUri(request);
if (!response.isCommitted()) {
if (response instanceof GrailsContentBufferingResponse) {
// clear the output from sitemesh before rendering error page
((GrailsContentBufferingResponse) response).deactivateSitemesh();
}
forwardRequest(info, request, response, mv, uri);
// return an empty ModelAndView since the error handler has been processed
return new ModelAndView();
Expand Down