[newchem-cpp] convert dynamic_api.c to dynamic_api.cpp#470
Open
mabruzzo wants to merge 24 commits intograckle-project:newchem-cppfrom
Open
[newchem-cpp] convert dynamic_api.c to dynamic_api.cpp#470mabruzzo wants to merge 24 commits intograckle-project:newchem-cppfrom
dynamic_api.c to dynamic_api.cpp#470mabruzzo wants to merge 24 commits intograckle-project:newchem-cppfrom
Conversation
mabruzzo
added
the
refactor
mabruzzo
force-pushed
the
ncc/cppify-dynamic-api
branch
from
78b9ab5 to
367a494
Compare
mabruzzo
force-pushed
the
ncc/cppify-dynamic-api
branch
from
367a494 to
7802d44
Compare
For context, the gmock library is a component of googletest (it's already being installed). All this commit does is make it possible for us to use it in subsequent PRs
In the process, I actually identified and fixed a minor bug
mabruzzo
force-pushed
the
ncc/cppify-dynamic-api
branch
from
7802d44 to
f8916fc
Compare
They are somewhat redundant with the new googletest tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #468 is merged
Before making any changes, I introduced a bunch of unit tests to test the API. Along the way, I actually identified a very minor edge case where our docs suggest that passing a
nullptras an argument should produce anullptrwhile we instead triggered a segmentation fault.Then I updated the logic. I needed to change the implementation. While what we were doing was valid C, it was almost certainly undefined behavior in C++.1
Footnotes
The code probably would have worked, but why risk it? The compiler implementers are free to do whatever they want when behavior is undefined. Plus, while the code may have worked today, this is the exact sort of thing that could break at an arbitrary time in the future ↩