[newchem-cpp] cleanup test_status_reporting.cpp#472
Open
mabruzzo wants to merge 8 commits intograckle-project:newchem-cppfrom
Open
[newchem-cpp] cleanup test_status_reporting.cpp#472mabruzzo wants to merge 8 commits intograckle-project:newchem-cppfrom
test_status_reporting.cpp#472mabruzzo wants to merge 8 commits intograckle-project:newchem-cppfrom
Conversation
For context, the gmock library is a component of googletest (it's already being installed). All this commit does is make it possible for us to use it in subsequent PRs
I was able to delete a bunch of unused junk. Furthermore, using gmock facillitated further simplifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #469 has been merged
This does 3 things:
test_status_reporting.cppFootnotes
For added context, googletest was previously being compiled with gmock. In fact the "DEATH TESTS" in this file make use of regex statements to match error messages. The main difference is that we are now using gmock directly ([newchem-cpp] mv grtest machinery into its own subdirectory #469 made this possible by explicitly linking test-code again the gmock library) ↩