[newchem-cpp] Tweaks to shorten some googletest names#473
Open
mabruzzo wants to merge 11 commits intograckle-project:newchem-cppfrom
Open
[newchem-cpp] Tweaks to shorten some googletest names#473mabruzzo wants to merge 11 commits intograckle-project:newchem-cppfrom
mabruzzo wants to merge 11 commits intograckle-project:newchem-cppfrom
Conversation
For context, the gmock library is a component of googletest (it's already being installed). All this commit does is make it possible for us to use it in subsequent PRs
(so that the test results are more readable)
mabruzzo
added
testing
mabruzzo
force-pushed
the
ncc/tweak-test-linalg
branch
from
9d822a7 to
2c6fc2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to be reviewed after #469 is merged
Prior to this PR, some of the tests that we implemented in googletest had names that were ridiculously long. As a consequence, over 300 characters were needed to print a single line. This made the output pretty unreadable.
This PR made a few tweaks so each line of the test-log only requires 100 characters (I would love to get it below 80 characters, but that requires more effort)