[newchem-cpp] mv dust cooling logic into functions called by cool1d_multi_g#486
Open
mabruzzo wants to merge 30 commits intograckle-project:newchem-cppfrom
Open
[newchem-cpp] mv dust cooling logic into functions called by cool1d_multi_g#486mabruzzo wants to merge 30 commits intograckle-project:newchem-cppfrom
cool1d_multi_g#486mabruzzo wants to merge 30 commits intograckle-project:newchem-cppfrom
Conversation
mabruzzo
force-pushed
the
ncc/relocate-dust-cooling
branch
3 times, most recently
from
7286b9e to
8573f72
Compare
mabruzzo
force-pushed
the
ncc/relocate-dust-cooling
branch
3 times, most recently
from
7de5498 to
171101b
Compare
…heat and update_edot_dust_recombination
mabruzzo
force-pushed
the
ncc/relocate-dust-cooling
branch
from
a75feb8 to
e537cff
Compare
mabruzzo
changed the title
cool1d_multi_g
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step at "cleaning up
cool1d_multi_g" (i.e. moving chunks of logic into discrete helper functions).This is a first stab at pulling out some of the logic pertaining to the dust-chemistry.
I have intentionally left the opacity-related dust logic in place. I have some specific ideas in mind for how to refactor this logic that will involve breaking the gold-standard, and I want to avoid doing that in this PR.