[newchem-cpp] introduce FullRxnRateBuf#494
Open
mabruzzo wants to merge 37 commits intograckle-project:newchem-cppfrom
Open
[newchem-cpp] introduce FullRxnRateBuf#494mabruzzo wants to merge 37 commits intograckle-project:newchem-cppfrom
FullRxnRateBuf#494mabruzzo wants to merge 37 commits intograckle-project:newchem-cppfrom
Conversation
…transcribe_cool1d_cloudy_old_tables_g
for more information, see https://pre-commit.ci
…ub.com/ChristopherBignamini/grackle into newchem-cpp_transcribe_rate_timestep_g
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…transcribe_rate_timestep_g
for more information, see https://pre-commit.ci
…ub.com/ChristopherBignamini/grackle into newchem-cpp_transcribe_rate_timestep_g
for more information, see https://pre-commit.ci
mabruzzo
force-pushed
the
ncc/FullRxnRateBuf
branch
2 times, most recently
from
2db8695 to
e4a79cb
Compare
mabruzzo
force-pushed
the
ncc/FullRxnRateBuf
branch
from
af58cc2 to
4ce92c8
Compare
…d radiative rates
mabruzzo
force-pushed
the
ncc/FullRxnRateBuf
branch
from
7fa5a5e to
7469407
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #482 and #442 are merged
This PR introduces
FullRxnRateBufwhich is intended to aggregate the various buffers used for holding intermediate reaction rate values.Longer term, it will probably be important for dynamically advancing the chemical network.
The majority of buffers to hold reaction rates are now organized within a single buffer. The lone exception are the radiative reaction rates, which are still tracked within
FullRxnRateBuf(as a followup, PR #496 builds on the changes from this PR and treats the radiative reaction rates in the same way as the rest of the reaction rates)The number of changed lines is actually much worse than it seems. In practice, there was a lot of search-and-replace. Going through this PR commit-by-commit should definitely help