Skip to content

fix Audio input in Multimodal Textbox not functional. #12999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freddyaboulton merged 2 commits into from
Mar 11, 2026
Merged

fix Audio input in Multimodal Textbox not functional. #12999

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0287b0
fix Audio input in Multimodal Textbox not functional.
JoaoPSC87 Mar 11, 2026
df032a1
Format
freddyaboulton Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions js/audio/shared/MinimalAudioPlayer.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@

let container: HTMLDivElement;
let waveform: WaveSurfer | undefined;
let playing = false;
let duration = 0;
let currentTime = 0;
let waveform_ready = false;
let playing = $state(false);
let duration = $state(0);
let currentTime = $state(0);
let waveform_ready = $state(false);

let resolved_src = $derived(value.url);

Expand Down
23 changes: 15 additions & 8 deletions js/audio/shared/MinimalAudioRecorder.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@

let container: HTMLDivElement;
let waveform: WaveSurfer | undefined;
let record: RecordPlugin | undefined;
let seconds = 0;
let record: RecordPlugin | undefined = $state();
let seconds = $state(0);
let interval: NodeJS.Timeout;
let is_recording = false;
let has_started = false;
let mic_devices: MediaDeviceInfo[] = [];
let selected_device_id: string = "";
let show_device_selection = false;
let is_recording = $state(false);
let has_started = $state(false);
let mic_devices: MediaDeviceInfo[] = $state([]);
let selected_device_id: string = $state("");
let show_device_selection = $state(false);

const start_interval = (): void => {
clearInterval(interval);
Expand Down Expand Up @@ -170,6 +170,9 @@
) {
record.startMic({ deviceId: selected_device_id }).then(() => {
record?.startRecording();
}).catch((err) => {
console.error("Failed to access microphone:", err);
onclear?.();
});
} else if (!recording && is_recording && record) {
record.stopRecording();
Expand Down Expand Up @@ -229,7 +232,11 @@
<button
class="stop-button"
onclick={() => {
recording = false;
if (is_recording) {
recording = false;
} else {
onclear?.();
}
}}
aria-label="Stop recording"
>
Expand Down
Loading