Skip to content

Return early if a Jar is not modified and all checks are disabled #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjohannes merged 1 commit into from
Jan 29, 2025
Merged

Return early if a Jar is not modified and all checks are disabled #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/main/java/org/gradlex/javamodule/moduleinfo/ExtraJavaModuleInfoTransform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,17 @@ public void transform(TransformOutputs outputs) {
if (willBeMerged(originalJar, moduleSpecs.values())) { // No output if this Jar will be merged
return;
}

// We return the original Jar without further analysis, if there is
// (1) no spec (2) no auto-module check (3) no missing module-info check (4) no auto-name derivation
if (moduleSpec == null
&& !getParameters().getFailOnAutomaticModules().get()
&& !getParameters().getFailOnMissingModuleInfo().get()
&& !getParameters().getDeriveAutomaticModuleNamesFromFileNames().get()) {
outputs.file(originalJar);
return;
}

boolean realModule = isModule(originalJar);
if (moduleSpec instanceof ModuleInfo) {
if (realModule && !((ModuleInfo) moduleSpec).patchRealModule) {
Expand Down