feat: add prometheus exporter and grafana dashboard#38
feat: add prometheus exporter and grafana dashboard#38zUZWqEHF wants to merge 2 commits intograelo:mainfrom
Conversation
|
Hi @crackerben99, thanks for this contribution! A Prometheus exporter is a valuable addition to pumas. Before we can merge this, there are a few things that need attention: PR DescriptionCould you add a description explaining:
Code Quality Issues
The PR has many
The HTTP server thread's JoinHandle is discarded. If that thread panics, the server silently stops responding while the main loop continues. Please either store the handle or add error handling.
Rebase RequiredThe codebase has changed since this PR was opened. Please rebase on current main. Notable changes:
Nice to have
Let me know if you have questions or need help with any of this! Thanks again for your effort! |
|
I almost forgot: i think it's worth considering putting the prometheus server in a separate crate. I'll let you provide your opinion on this idea. Thanks! |
No description provided.