Skip to content

Conversation

@Lasica
Copy link

@Lasica Lasica commented Feb 11, 2022

Description

Fixing bugs in annotation api parameters and fixing issue with ambivalence when payload is returned in not json format and the string search is performed instead in: "message" in <var>. Originally filed at m0nhawk/grafana_api#89.

Checklist

  • The patch has appropriate test coverage
  • The patch follows the style guidelines of this project
  • The patch has appropriate comments, particularly in hard-to-understand areas
  • The documentation was updated corresponding to the patch
  • I have performed a self-review of this patch

@Lasica Lasica requested a review from amotl as a code owner February 11, 2022 09:49
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #10 (43a2258) into main (170121a) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files          17       17           
  Lines         663      663           
=======================================
  Hits          581      581           
  Misses         82       82           
Impacted Files Coverage Δ
grafana_client/elements/annotations.py 96.42% <0.00%> (ø)
grafana_client/client.py 93.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 170121a...43a2258. Read the comment docs.

@amotl
Copy link
Contributor

amotl commented Feb 15, 2022

Dear Artur,

thank you very much for contributing this improvement.

With kind regards,
Andreas.

@amotl amotl merged commit 8aa9653 into grafana-toolbox:main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants