Fix "folderId" propagation for "update_dashboard" #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the "folderId" is not available within the dashboard payload, populate it from the nested "meta" object, if given. On the other hand, if it *is* given within the dashboard payload, it should take precedence.
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 87.48% 87.55% +0.07%
==========================================
Files 17 17
Lines 655 659 +4
==========================================
+ Hits 573 577 +4
Misses 82 82
Continue to review full report at Codecov.
|
|
Thanks @amotl 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
coming from the original patch m0nhawk/grafana_api#85, this fixes m0nhawk/grafana_api#82. Users reported the original flaw through grafana-toolbox/grafana-wtf#5.
When the
folderIdis not available within the dashboard payload, populate it from the nestedmetaobject, if given. On the other hand, if it is given within the dashboard payload, it should take precedence.With kind regards,
Andreas.
/cc @pierluigilenoci, @JackNelson