Skip to content

Conversation

@soonann
Copy link

@soonann soonann commented Feb 3, 2025

This PR fixes a bug where datasources that were being used in dashboards through variables were being wrongly categorised as unused (in explore datasources) and missing (in explore dashboards).

The full description of the problem can be seen in the issue #164 along with steps to reproduce it.

@soonann soonann changed the title fix: variable datasources shown as missing datasource fix: variable datasources shown as missing and unused datasource Feb 3, 2025
@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.20%. Comparing base (f756410) to head (12294d4).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files           9        9           
  Lines        1109     1109           
=======================================
  Hits          956      956           
  Misses        153      153           
Flag Coverage Δ
unittests 86.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl
Copy link
Contributor

amotl commented Feb 3, 2025

Thank you very much for reporting and submitting a fix for GH-164.

@amotl amotl merged commit 403a922 into grafana-toolbox:main Feb 3, 2025
17 checks passed
@amotl amotl added the bug Something isn't working label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants