Skip to content

Conversation

@edwelker
Copy link
Contributor

There was a typo in the README where the example to find a dashboards by data source name was trying to match against the "type" field, not the "name" field.

There was a typo in the README where the example to find a dashboards by data source name was trying to match against the "type" field, not the "name" field.
Copy link
Contributor

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. We appreciate your attention to detail, and for taking the time to submit a fix.

@amotl amotl requested a review from nikodemas February 26, 2025 01:44
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.01%. Comparing base (8c82149) to head (f8527f1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   85.01%   85.01%           
=======================================
  Files           9        9           
  Lines        1121     1121           
=======================================
  Hits          953      953           
  Misses        168      168           
Flag Coverage Δ
unittests 85.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edwelker edwelker requested a review from amotl February 26, 2025 15:54
Copy link
Contributor

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amotl amotl merged commit c5783ce into grafana-toolbox:main Feb 27, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants