Skip to content

Conversation

@nikodemas
Copy link
Member

Hi @amotl,

I wasn't able to run grafana-wtf with the verlib2 0.3.0, so I think this change should prevent this problem.

@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.01%. Comparing base (fc19062) to head (fdaa777).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   85.01%   85.01%           
=======================================
  Files           9        9           
  Lines        1121     1121           
=======================================
  Hits          953      953           
  Misses        168      168           
Flag Coverage Δ
unittests 85.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@amotl amotl merged commit 8c82149 into grafana-toolbox:main Feb 26, 2025
17 checks passed
@amotl
Copy link
Contributor

amotl commented Feb 27, 2025

Do you think a new release should be published?

@nikodemas
Copy link
Member Author

I don't see a strong need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants