Fix collecting data sources defined by dashboard variables

[amotl]

Problem

When data sources are defined by dashboard variables, a ton of warnings like Data source 'datasource-3' not found are emitted.

Observations

It looks like resolving this bit of information beared a programming error.

Solution

@cronosnull suggested an excellent improvement. Thanks!

I think the values in the variables are data source names, but not completely sure, so I would support both cases.

[coderabbitai]

Summary by CodeRabbit

• Bug Fixes

  • Resolved an issue where data sources defined by dashboard variables were not being collected correctly.
  • Improved error handling and messaging when a datasource cannot be found by name.

• Documentation

  • Updated the changelog to reflect the fix for collecting data sources defined by dashboard variables and acknowledged contributors.

Walkthrough

The changelog was updated to document a fix for collecting data sources defined via dashboard variables. The core logic in Indexer.collect_datasource_items was modified to use datasource names instead of UIDs for lookup, updating variable names and log messages accordingly. No public interfaces or exported entity signatures were changed.

Changes

File(s)	Change Summary
CHANGES.rst	Updated changelog to note fix for collecting data sources defined by dashboard variables.
grafana_wtf/core.py	Changed internal lookup in Indexer.collect_datasource_items from datasource UID to name.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A bunny hopped through code so bright,
Fixing datasources, making things right.
From UID to name, the lookup is clear,
Now dashboard variables gather near.
With changelog updated, the warren is calm,
Another quick patch—reviewers, stay warm! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5311c45 and 847811d.

📒 Files selected for processing (2)

• CHANGES.rst (1 hunks)
• grafana_wtf/core.py (1 hunks)

🔇 Additional comments (2)

grafana_wtf/core.py (1)

718-721: LGTM! Critical fix for datasource variable handling.

The change from using datasource UIDs to names for lookup is correct and addresses the core issue. Dashboard variables typically reference datasources by name rather than UID, so using self.datasource_by_name instead of self.datasource_by_uid properly resolves datasource references defined through dashboard variables.

The updated variable naming (ds_name instead of ds_uid) and log message also improve code clarity and debugging.

CHANGES.rst (1)

10-11: Well-documented changelog entry.

The changelog entry accurately describes the fix and properly credits the contributors. The description is clear and concise, helping users understand what issue was resolved.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-datasource-as-variable

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.45%. Comparing base (5311c45) to head (847811d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files           9        9           
  Lines        1126     1126           
=======================================
  Hits          951      951           
  Misses        175      175           

Flag	Coverage Δ
unittests	84.45% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[cronosnull]

LGTM!
Thanks!