fix(traceVisQuery): Select lower(SpanKind) for compatibility with PeerService visualization#1736
Draft
jSwanson99 wants to merge 1 commit intografana:mainfrom
Draft
fix(traceVisQuery): Select lower(SpanKind) for compatibility with PeerService visualization#1736jSwanson99 wants to merge 1 commit intografana:mainfrom
jSwanson99 wants to merge 1 commit intografana:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Please check the relevant option.
Bug Fix
What is the bug?
The grafana trace vis expect SpanKind to be in lowercase, and not providing it in lowercase results in your client spans not being recognized as client spans. Here is where its checked: TraceTimelineViewer/utils.tsx
The reason why its useful for this check to be accurate, is because the PeerService functionality requires the SpanKind of the associated span to be client. See attached images to see what this functionality is. Here's where the vis cares about SpanKind VirtualizedTraceView.tsx
How to reproduce
Environment (if no related issue)
If there is no open issue, please specify the versions where the bug occurs.
Screenshots / Videos
Please provide screenshots or videos demonstrating the bug or the feature working. This helps reviewers understand the change visually and speeds up the review process.
Before:

After:

Its a small change that's quite helpful when you don't own the service which you are calling
Please check that:
I'd say docs update is not applicable. Its a feature of otel https://opentelemetry.io/docs/specs/semconv/registry/attributes/peer/
Special notes for your reviewer
Use this section for any additional information that may help the reviewer, such as implementation decisions, areas of concern, or context that doesn't fit elsewhere. If you'd like to request review or feedback on a specific part of your changes, please note that here.