Skip to content

feat: improve query modification#1738

Open
karl-power wants to merge 1 commit intografana:mainfrom
karl-power:improve-query-modification
Open

feat: improve query modification#1738
karl-power wants to merge 1 commit intografana:mainfrom
karl-power:improve-query-modification

Conversation

@karl-power
Copy link
Copy Markdown
Collaborator

@karl-power karl-power commented Mar 20, 2026

Changes

  • Implements DataSourceWithQueryModificationSupport on the Datasource, adding the getSupportedQueryModifications method which returns:
['ADD_FILTER', 'ADD_FILTER_OUT', 'ADD_STRING_FILTER', 'ADD_STRING_FILTER_OUT'].
  • This change enables the Logs Popover Menu shown in screenshot below, which has both the ADD_STRING_FILTER and ADD_STRING_FILTER_OUT options.
  • Adds new filter operators ILIKE and NOT ILIKE to be used with this new filter options.
  • When selecting either of the new filters from the popover menu, no key is provided in the call to modifyQuery, so we use the log message column for the filters, getting that from the column hint.
  • Only works in query builder mode, like the existing ADD_FILTER and ADD_FILTER_OUT modifications

Screenshots

Screenshot 2026-03-20 at 12 57 05

@karl-power karl-power force-pushed the improve-query-modification branch from ccac6d4 to 47a7d9f Compare March 20, 2026 12:15
@adamyeats adamyeats moved this from Incoming to Needs Review in Partner Datasources Mar 20, 2026
Copy link
Copy Markdown
Collaborator

@SpencerTorres SpencerTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! Appreciate the tests 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

3 participants