feat: add disableTraceLinks and disableLogLinks config options#1751
Closed
rabunkosar-dd wants to merge 1 commit intografana:mainfrom
Closed
feat: add disableTraceLinks and disableLogLinks config options#1751rabunkosar-dd wants to merge 1 commit intografana:mainfrom
rabunkosar-dd wants to merge 1 commit intografana:mainfrom
Conversation
Add separate boolean toggles to opt out of automatic data links injected on trace_id fields. `disableTraceLinks` (traces config) suppresses the "View trace" link; `disableLogLinks` (logs config) suppresses the "View logs" link. Both options are wired in CHConfigEditor and the config-v2 editor, and are guarded independently in transformQueryResponseWithTraceAndLogLinks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rabunkosar-dd
requested review from
aangelisc,
adamyeats,
alyssajoyner,
bossinc and
ryanmorris708
Author
|
Since #1754 is a superset, no need for this PR anymore, closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Please check the relevant option.
Feature
If this is a feature, please complete this section. Otherwise, delete it.
What is this feature?
Add separate boolean toggles to opt out of automatic data links injected on trace_id fields.
disableTraceLinks(traces config) suppresses the "View trace" link;disableLogLinks(logs config) suppresses the "View logs" link. Both options are wired in CHConfigEditor and the config-v2 editor, and are guarded independently in transformQueryResponseWithTraceAndLogLinks.Why is this feature needed?
The links are visible even when the datasource is not configured, creating problematic links
How to test this feature
Provide step-by-step instructions for reviewers to test the feature.