docs(diagrams): adding diagrams for call, flow, and sub-package structure#791
Open
stephan-rayner wants to merge 2 commits intomainfrom
Open
docs(diagrams): adding diagrams for call, flow, and sub-package structure#791stephan-rayner wants to merge 2 commits intomainfrom
stephan-rayner wants to merge 2 commits intomainfrom
Conversation
stephan-rayner
added
documentation
Author
|
@nikimanoledaki could I trouble you particularly to take a look at this one. I imagine you may know this well enough to know if I missed anything. I typically make something like this to help me understand a project better 😄 |
Contributor
There was a problem hiding this comment.
The diagrams and info is all correct 👍 😄 It's nice to have a visualisation for this!
My only concern is how this diagram will scale as we add more services for each provider. One way we could solve this is by showing a single service per provider as an example rather than a list of all of them. There are some outliers though like the AWS EC2 service, which has some unique stuff compared to the other ones. We could generalise the flow enough that it covers them all. WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.