Skip to content

Fix factories signatures in java#1009

Merged
K-Phoen merged 2 commits intomainfrom
fix-java-builders-signatures
Feb 24, 2026
Merged

Fix factories signatures in java#1009
K-Phoen merged 2 commits intomainfrom
fix-java-builders-signatures

Conversation

@K-Phoen
Copy link
Member

@K-Phoen K-Phoen commented Feb 24, 2026

@K-Phoen K-Phoen added the bug Something isn't working label Feb 24, 2026
@K-Phoen K-Phoen requested a review from a team as a code owner February 24, 2026 12:16
@github-actions
Copy link

Note: the diff show code changes that would be introduced by this PR to the output of the Grafana Foundation SDK codegen pipeline.

🔎 Changes to Grafana Foundation SDK

diff --new-file --unidirectional-new-file '--color=never' --unified --recursive '--exclude=.git' '--exclude=gradle.properties' '--exclude=pyproject.toml' '--exclude=package.json' '--exclude=*.md' /tmp/foundation-workspace-main/foundation-sdk/java/src/main/java/com/grafana/foundation/dashboardv2beta1/Dashboardv2beta1.java /tmp/foundation-workspace-current/foundation-sdk/java/src/main/java/com/grafana/foundation/dashboardv2beta1/Dashboardv2beta1.java
--- /tmp/foundation-workspace-main/foundation-sdk/java/src/main/java/com/grafana/foundation/dashboardv2beta1/Dashboardv2beta1.java	2026-02-24 12:23:16.795863026 +0000
+++ /tmp/foundation-workspace-current/foundation-sdk/java/src/main/java/com/grafana/foundation/dashboardv2beta1/Dashboardv2beta1.java	2026-02-24 12:22:35.580986022 +0000
@@ -3,13 +3,12 @@
 package com.grafana.foundation.dashboardv2beta1;
 
 import com.grafana.foundation.resource.ManifestBuilder;
-import com.grafana.foundation.resource.Manifest;
 import com.grafana.foundation.resource.Resource;
 public class Dashboardv2beta1 {    
     /**
      * Creates a resource manifest from a Dashboard.
      */
-    public static com.grafana.foundation.cog.Builder<Manifest> manifest(String name,com.grafana.foundation.cog.Builder<Dashboard> dashboard) {
+    public static ManifestBuilder manifest(String name,com.grafana.foundation.cog.Builder<Dashboard> dashboard) {
         ManifestBuilder builder = new ManifestBuilder();
         builder.apiVersion("dashboard.grafana.app/v2beta1");
         builder.kind("Dashboard");
diff --new-file --unidirectional-new-file '--color=never' --unified --recursive '--exclude=.git' '--exclude=gradle.properties' '--exclude=pyproject.toml' '--exclude=package.json' '--exclude=*.md' /tmp/foundation-workspace-main/foundation-sdk/java/src/main/java/com/grafana/foundation/folderv1beta1/Folderv1beta1.java /tmp/foundation-workspace-current/foundation-sdk/java/src/main/java/com/grafana/foundation/folderv1beta1/Folderv1beta1.java
--- /tmp/foundation-workspace-main/foundation-sdk/java/src/main/java/com/grafana/foundation/folderv1beta1/Folderv1beta1.java	2026-02-24 12:23:16.811862964 +0000
+++ /tmp/foundation-workspace-current/foundation-sdk/java/src/main/java/com/grafana/foundation/folderv1beta1/Folderv1beta1.java	2026-02-24 12:22:35.598985983 +0000
@@ -3,13 +3,12 @@
 package com.grafana.foundation.folderv1beta1;
 
 import com.grafana.foundation.resource.ManifestBuilder;
-import com.grafana.foundation.resource.Manifest;
 import com.grafana.foundation.resource.Resource;
 public class Folderv1beta1 {    
     /**
      * Creates a resource manifest from a Folder.
      */
-    public static com.grafana.foundation.cog.Builder<Manifest> manifest(String name,com.grafana.foundation.cog.Builder<Folder> folder) {
+    public static ManifestBuilder manifest(String name,com.grafana.foundation.cog.Builder<Folder> folder) {
         ManifestBuilder builder = new ManifestBuilder();
         builder.apiVersion("folder.grafana.app/v1beta1");
         builder.kind("Folder");
diff --new-file --unidirectional-new-file '--color=never' --unified --recursive '--exclude=.git' '--exclude=gradle.properties' '--exclude=pyproject.toml' '--exclude=package.json' '--exclude=*.md' /tmp/foundation-workspace-main/foundation-sdk/java/src/main/java/com/grafana/foundation/playlistv0alpha1/Playlistv0alpha1.java /tmp/foundation-workspace-current/foundation-sdk/java/src/main/java/com/grafana/foundation/playlistv0alpha1/Playlistv0alpha1.java
--- /tmp/foundation-workspace-main/foundation-sdk/java/src/main/java/com/grafana/foundation/playlistv0alpha1/Playlistv0alpha1.java	2026-02-24 12:23:16.816862945 +0000
+++ /tmp/foundation-workspace-current/foundation-sdk/java/src/main/java/com/grafana/foundation/playlistv0alpha1/Playlistv0alpha1.java	2026-02-24 12:22:35.603985973 +0000
@@ -3,13 +3,12 @@
 package com.grafana.foundation.playlistv0alpha1;
 
 import com.grafana.foundation.resource.ManifestBuilder;
-import com.grafana.foundation.resource.Manifest;
 import com.grafana.foundation.resource.Resource;
 public class Playlistv0alpha1 {    
     /**
      * Creates a resource manifest from a Playlist.
      */
-    public static com.grafana.foundation.cog.Builder<Manifest> manifest(String name,com.grafana.foundation.cog.Builder<Playlist> playlist) {
+    public static ManifestBuilder manifest(String name,com.grafana.foundation.cog.Builder<Playlist> playlist) {
         ManifestBuilder builder = new ManifestBuilder();
         builder.apiVersion("playlist.grafana.app/playlistv0alpha1");
         builder.kind("Playlist");
diff --new-file --unidirectional-new-file '--color=never' --unified --recursive '--exclude=.git' '--exclude=gradle.properties' '--exclude=pyproject.toml' '--exclude=package.json' '--exclude=*.md' /tmp/foundation-workspace-main/foundation-sdk/java/src/main/java/com/grafana/foundation/preferencesv1alpha1/Preferencesv1alpha1.java /tmp/foundation-workspace-current/foundation-sdk/java/src/main/java/com/grafana/foundation/preferencesv1alpha1/Preferencesv1alpha1.java
--- /tmp/foundation-workspace-main/foundation-sdk/java/src/main/java/com/grafana/foundation/preferencesv1alpha1/Preferencesv1alpha1.java	2026-02-24 12:23:16.817862941 +0000
+++ /tmp/foundation-workspace-current/foundation-sdk/java/src/main/java/com/grafana/foundation/preferencesv1alpha1/Preferencesv1alpha1.java	2026-02-24 12:22:35.603985973 +0000
@@ -3,13 +3,12 @@
 package com.grafana.foundation.preferencesv1alpha1;
 
 import com.grafana.foundation.resource.ManifestBuilder;
-import com.grafana.foundation.resource.Manifest;
 import com.grafana.foundation.resource.Resource;
 public class Preferencesv1alpha1 {    
     /**
      * Creates a resource manifest from Preferences.
      */
-    public static com.grafana.foundation.cog.Builder<Manifest> manifest(String name,com.grafana.foundation.cog.Builder<Preferences> preferences) {
+    public static ManifestBuilder manifest(String name,com.grafana.foundation.cog.Builder<Preferences> preferences) {
         ManifestBuilder builder = new ManifestBuilder();
         builder.apiVersion("preferences.grafana.app/v1alpha1");
         builder.kind("Preferences");
diff --new-file --unidirectional-new-file '--color=never' --unified --recursive '--exclude=.git' '--exclude=gradle.properties' '--exclude=pyproject.toml' '--exclude=package.json' '--exclude=*.md' /tmp/foundation-workspace-main/foundation-sdk/java/src/main/java/com/grafana/foundation/resource/Resource.java /tmp/foundation-workspace-current/foundation-sdk/java/src/main/java/com/grafana/foundation/resource/Resource.java
--- /tmp/foundation-workspace-main/foundation-sdk/java/src/main/java/com/grafana/foundation/resource/Resource.java	2026-02-24 12:23:16.817862941 +0000
+++ /tmp/foundation-workspace-current/foundation-sdk/java/src/main/java/com/grafana/foundation/resource/Resource.java	2026-02-24 12:22:35.604985970 +0000
@@ -6,7 +6,7 @@
     /**
      * Creates metadata for a named resource.
      */
-    public static com.grafana.foundation.cog.Builder<Metadata> named(String name) {
+    public static MetadataBuilder named(String name) {
         MetadataBuilder builder = new MetadataBuilder();
         builder.name(name);
         return builder;
diff --new-file --unidirectional-new-file '--color=never' --unified --recursive '--exclude=.git' '--exclude=gradle.properties' '--exclude=pyproject.toml' '--exclude=package.json' '--exclude=*.md' /tmp/foundation-workspace-main/foundation-sdk/java/src/main/java/com/grafana/foundation/starsv1alpha1/Starsv1alpha1.java /tmp/foundation-workspace-current/foundation-sdk/java/src/main/java/com/grafana/foundation/starsv1alpha1/Starsv1alpha1.java
--- /tmp/foundation-workspace-main/foundation-sdk/java/src/main/java/com/grafana/foundation/starsv1alpha1/Starsv1alpha1.java	2026-02-24 12:23:16.818862937 +0000
+++ /tmp/foundation-workspace-current/foundation-sdk/java/src/main/java/com/grafana/foundation/starsv1alpha1/Starsv1alpha1.java	2026-02-24 12:22:35.604985970 +0000
@@ -3,13 +3,12 @@
 package com.grafana.foundation.starsv1alpha1;
 
 import com.grafana.foundation.resource.ManifestBuilder;
-import com.grafana.foundation.resource.Manifest;
 import com.grafana.foundation.resource.Resource;
 public class Starsv1alpha1 {    
     /**
      * Creates a resource manifest from Stars.
      */
-    public static com.grafana.foundation.cog.Builder<Manifest> manifest(String name,com.grafana.foundation.cog.Builder<Stars> stars) {
+    public static ManifestBuilder manifest(String name,com.grafana.foundation.cog.Builder<Stars> stars) {
         ManifestBuilder builder = new ManifestBuilder();
         builder.apiVersion("preferences.grafana.app/v1alpha1");
         builder.metadata(Resource.named(name));

@K-Phoen K-Phoen merged commit ed69c2d into main Feb 24, 2026
13 checks passed
@K-Phoen K-Phoen deleted the fix-java-builders-signatures branch February 24, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant