Open
Conversation
3 tasks
grafana-plugins-platform-bot
bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
| "eslint-config-prettier": ">=8.8.0", | ||
| "eslint-plugin-jsdoc": ">=46.8.0", | ||
| "eslint-plugin-react": ">=7.33.0", | ||
| "@stylistic/eslint-plugin": ">=5.0.0", |
Contributor
There was a problem hiding this comment.
❤️ goodbye deprecation warning message?
Comment on lines
+102
to
+111
| // disable the following react-hooks rules for easy adoption in grafana/grafana | ||
| "react-hooks/refs": "off", | ||
| "react-hooks/set-state-in-effect": "off", | ||
| "react-hooks/immutability": "off", | ||
| "react-hooks/preserve-manual-memoization": "off", | ||
| "react-hooks/purity": "off", | ||
| "react-hooks/static-components": "off", | ||
| "react-hooks/use-memo": "off", | ||
| "react-hooks/incompatible-library": "off", | ||
| "react-hooks/unsupported-syntax": "off", |
Contributor
There was a problem hiding this comment.
Side thought: Could we leave them on, but disable only in the grafana/grafana repo? So anyone else using this will get them turned on?
Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes legacy config support in favour of flat config (which has been available since v8.57 of Eslint) and makes the package ESM only.
It also tinkers with the react-hooks rules to make for easier adoption in larger projects (such as grafana/grafana where we get over 600 errors).
fixes: #70
fixes: #45