Introduce resource.PartialObject and k8s.DeferredNegotiatedSerializer…#1024
Open
IfSentient wants to merge 2 commits intomainfrom
Open
Introduce resource.PartialObject and k8s.DeferredNegotiatedSerializer…#1024IfSentient wants to merge 2 commits intomainfrom
IfSentient wants to merge 2 commits intomainfrom
Conversation
… to allow for deferring more expensive unmarshaling for a given kind.
radiohead
reviewed
Oct 20, 2025
Contributor
radiohead
left a comment
There was a problem hiding this comment.
A couple of minor comments, but also, could we add a benchmark? Something like:
// resource/partialobject_test.go
func BenchmarkPartialObjectUnmarshal(b *testing.B) {
data := []byte(`{"apiVersion":"v1","kind":"Pod","metadata":{"name":"test","namespace":"default"},"spec":{"containers":[...]}}`)
for i := 0; i < b.N; i++ {
var obj PartialObject
_ = json.Unmarshal(data, &obj)
}
}
func BenchmarkTypedObjectUnmarshal(b *testing.B) {
data := []byte(`{"apiVersion":"v1","kind":"Pod","metadata":{"name":"test","namespace":"default"},"spec":{"containers":[...]}}`)
for i := 0; i < b.N; i++ {
var obj TypedSpecObject[PodSpec]
_ = json.Unmarshal(data, &obj)
}
}| func NewApp(config AppConfig) (*App, error) { | ||
| clients := config.ClientGenerator | ||
| if clients == nil { | ||
| k8s.NewClientRegistry(config.KubeConfig, k8s.DefaultClientConfig()) |
Contributor
There was a problem hiding this comment.
Suggested change
| k8s.NewClientRegistry(config.KubeConfig, k8s.DefaultClientConfig()) | |
| clients = k8s.NewClientRegistry(config.KubeConfig, k8s.DefaultClientConfig()) |
Contributor
There was a problem hiding this comment.
Note, that this should go away after syncing with main, since #1023 was merged.
Comment on lines
+37
to
+38
| p.TypeMeta = *md.TypeMeta | ||
| p.ObjectMeta = *md.ObjectMeta |
Contributor
There was a problem hiding this comment.
These could be nil, couldn't they?
Contributor
|
@IfSentient this didn't get any traction, should we drop it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
resource.PartialObjectandk8s.DeferredNegotiatedSerializerto allow for deferring more expensive unmarshaling for a given kind. This is an experimental feature to see if this accelerates initial start-up processing of large numbers of objects in CPU-constrained environments, and may be removed in a future release if not effective.Includes changes from not-yet-merged #1023 to allow specifying the negotiated serializer using
k8s.ClientConfig.