Skip to content

Update npm in publish-npm.yml only when node is setup #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 7, 2025
Merged

Update npm in publish-npm.yml only when node is setup #309

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09ed6d9
Update npm in publish-npm.yml only when node is setup
kevinwcyu Oct 7, 2025
51bc4b9
Merge branch 'main' into kevinwcyu/fix-publish-npm
kevinwcyu Oct 7, 2025
b9474aa
fix comment
kevinwcyu Oct 7, 2025
712caff
add environment to workflow
kevinwcyu Oct 7, 2025
d9591f2
remove --scope flag as it does nothing here
kevinwcyu Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/publish-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ jobs:
npm-publish:
name: Publish to NPM & GitHub Package Registry
runs-on: ubuntu-latest
# Required for this workflow to have permission to publish NPM packages
environment: release
permissions:
contents: read
packages: write
# id-token: write required for get-vault-secrets and trusted publishing
# id-token: write required for npm trusted publishing
id-token: write
outputs:
new_version: ${{ steps.version_check.outputs.version }}
Expand Down Expand Up @@ -47,6 +49,7 @@ jobs:
registry-url: 'https://registry.npmjs.org'

- name: Install npm version ^11.5.1 # npm trusted publishing requires version ^11.5.1
if: steps.version_check.outputs.changed == 'true'
run: npm install -g npm@^11.5.1

- name: Install dependencies
Expand Down