Feat: get externalId for Grafana Assume Role in the frontend #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njvrzm
requested review from
iwysiu and
kevinwcyu
and removed request for
a team
idastambuk
approved these changes
Oct 8, 2025
njvrzm
force-pushed
the
njvrzm/temp-credentials-external-id-frontend
branch
from
e3d9e5b to
bb8ea11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Grafana Assume Role we need an externalId, which is currently passed by a very convoluted route, but is in fact always the stack ID, which is already present in the GrafanaConfig. This adds support for getting externalId directly and will allow us to eliminate the existing resource handlers like this and not add any new ones as we expand support for Grafana Assume role.
This also prepares a new release.