Tests: use go-pdfium for validating generated fixtures#956
Open
Tests: use go-pdfium for validating generated fixtures#956
Conversation
|
🐳 Docker image built and pushed to GitHub Container Registry. You can pull it using: docker pull ghcr.io/grafana/grafana-image-renderer:dev-pull-956-1d1cadd9bc45bd97d76629597229d15fc4dc5d0bWarning This is a development image and should not be used in production. |
macabu
force-pushed
the
macabu/remove-pdf-deps
branch
from
c20dc8c to
c1185d5
Compare
macabu
force-pushed
the
macabu/remove-pdf-deps
branch
from
c1185d5 to
749b779
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
gen2brain/go-fitzandgithub.com/unidoc/unipdfin favour ofklippa-app/go-pdfium+ wasmFixtures are the same size, but got regenerated and the end result is virtually the same, there's still a diff since it uses a different library to generate the fixtures.