Fix OATS workflow #137
Merged
Fix OATS workflow #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hit my go knowledge wall here pretty fast 😅 @zeitlinger Is this something that needs fixing in the oats repo itself so the fix comes with the clone? |
This OATs setup is deprecated - not sure if the question still applies when updated. This is my reference setup - where |
|
Ok cool, in that case I'll update this to use the other way when I get back to it. |
|
Depends on grafana/oats#109. |
martincostello
commented
Jun 2, 2025
Merged
- Upgrade Go to 1.24. - Remove permissions from all jobs. - Avoid warning if no error logs found. - Allow manual dispatch.
Run `go mod tidy` to see if that fixes things.
Try running it later.
Just while I don't know what the real fix is.
Didn't fix it, but it's further along with the first one.
Install OATS directly instead of cloning.
Consume changes from grafana/oats#109 to fix matrix usage.
Remove obsolete `version` property.
Update from .NET 6 to .NET 8.
.NET 8 changed the default container port to `8080`.
Update commands to run OATS tests.
Map port 8080 for ASP.NET Core.
Add a PowerShell script to run the OATS tests locally cross-platform.
Set the executable bit for macOS and Linux.
Remove references to non-existent compose file.
Avoid prerelease versions of the .NET SDK if installed locally.
Fix (and simplify) the ASP.NET Core dockerfile.
Fix timeout no longer being consumed from `TESTCASE_TIMEOUT` env var and instead use `--timeout` flag.
Container name is `lgtm` not `container`.
Fix names based on docker-otel-lgtm's .NET example.
Fix self-contained publish not working due to quotes.
Add OTLP logging.
Add whitespace to make things more readable.
Add log query (which needs to be fixed).
Configure logging in the right way.
Fix metric names.
Fix trace query for `GetError`.
Use the latest stable release of OATS.
Expose port 1433 so that the application can connect to it.
Fix incorrect attributes.
Update traceql to match HTTP test cases.
Then we know if we break things.
- Use primary constructors. - Remove unused fields. - Use structured logging. - Use `await using`. - Use HttpClientFactory. - Use async methods where available. - Use collection expressions.
Use `span.http.route` instead of `name`.
Combine the OATS tests into a single file to speed up the execution time by avoiding spinning containers up and down so much.
Pin OATS to v0.3.2 and configure renovate.
martincostello
commented
Jun 4, 2025
Revert redundant change.
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
versionproperty from docker compose files.80to8080(docs).Merge requirement checklist
CHANGELOG.mdfile updated for non-trivial changes