-
Notifications
You must be signed in to change notification settings - Fork 9
Explain OTEL_EXPORTER_OTLP_HEADERS #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9660d56
to
9a5cb20
Compare
export OTEL_EXPORTER_OTLP_HEADERS="Authorization=Basic base64-encoded-string" | ||
``` | ||
|
||
> [!TIP] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a custom Hugo shortcode for notes https://grafana.com/docs/writers-toolkit/write/shortcodes/#admonition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is only rendered in GitHub so we need to use their syntax, not Hugo's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Do you think it will be useful adding our OpenTelemetry VS Code copilot-instructions.md to this repo?
Do you have a link to which repo? Having the docs-specific ones in the distro repo feels OTT to me considering their length compared to this mostly being a code repo, not a docs one. |
9a5cb20
to
1c91ff5
Compare
We can scope instructions to specific paths and file types. Here's the file https://github.com/grafana/opentelemetry-docs/blob/main/.github/copilot-instructions.md |
@grafsean Just finally coming back to this - that instructions file is in a private repo. Is it OK for me to copy into this public repo as-is? |
Yes that's fine. You can also add it is a user instruction file if you prefer. |
Explain how the value of `OTEL_EXPORTER_OTLP_HEADERS` is derived.
Add Copilot instructions for documentation.
1c91ff5
to
8559bbb
Compare
Disable various markdownlint warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the documentation by explaining how to construct the OTEL_EXPORTER_OTLP_HEADERS
authentication token value. The change replaces a placeholder token with a more descriptive one and adds a detailed explanation of the base64 encoding process for Basic authentication with Grafana Cloud.
- Clarifies that the Basic authentication token is a base64-encoded string
- Adds comprehensive explanation with concrete example showing Instance ID and API key encoding
- Improves user understanding of the authentication mechanism
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
File | Description |
---|---|
README.md | Updated authentication header example and added detailed explanation of base64 encoding process |
.github/copilot-instructions.md | Added comprehensive Grafana Labs documentation style guide and writing standards |
Fix typos. Co-authored-by: Copilot <[email protected]>
README.md
Outdated
> The token for `Basic` authentication is the base64-encoded value of a Grafana | ||
> Cloud Instance ID and an API key separated by a `:`. | ||
> | ||
> For example, if your Grafana Cloud Instance ID is `12345` and your API key is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API keys have been deprecated, replaced with with "service account tokens".
Exact naming is inconsistent depending on where you generate a token (service account token/API token/token/Grafana Cloud Access token/etc) but they are distinct from the older key based auth.
"service account token" not "API key".
Explain how the value of
OTEL_EXPORTER_OTLP_HEADERS
is derived.