Skip to content

Conversation

martincostello
Copy link
Member

Explain how the value of OTEL_EXPORTER_OTLP_HEADERS is derived.

@martincostello martincostello added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 4, 2025
@martincostello martincostello marked this pull request as ready for review June 4, 2025 16:20
@martincostello martincostello requested a review from a team as a code owner June 4, 2025 16:20
@martincostello martincostello enabled auto-merge (squash) June 4, 2025 16:20
@martincostello martincostello disabled auto-merge June 5, 2025 12:39
@martincostello martincostello marked this pull request as draft June 5, 2025 12:39
export OTEL_EXPORTER_OTLP_HEADERS="Authorization=Basic base64-encoded-string"
```

> [!TIP]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is only rendered in GitHub so we need to use their syntax, not Hugo's.

Copy link

@grafsean grafsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Do you think it will be useful adding our OpenTelemetry VS Code copilot-instructions.md to this repo?

@martincostello
Copy link
Member Author

Do you think it will be useful adding our OpenTelemetry VS Code copilot-instructions.md to this repo?

Do you have a link to which repo? Having the docs-specific ones in the distro repo feels OTT to me considering their length compared to this mostly being a code repo, not a docs one.

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2025

CLA assistant check
All committers have signed the CLA.

@grafsean
Copy link

grafsean commented Jun 13, 2025

Do you have a link to which repo? Having the docs-specific ones in the distro repo feels OTT to me considering their length compared to this mostly being a code repo, not a docs one.

We can scope instructions to specific paths and file types. Here's the file https://github.com/grafana/opentelemetry-docs/blob/main/.github/copilot-instructions.md

@martincostello
Copy link
Member Author

@grafsean Just finally coming back to this - that instructions file is in a private repo. Is it OK for me to copy into this public repo as-is?

@grafsean
Copy link

@grafsean Just finally coming back to this - that instructions file is in a private repo. Is it OK for me to copy into this public repo as-is?

Yes that's fine. You can also add it is a user instruction file if you prefer.

Explain how the value of `OTEL_EXPORTER_OTLP_HEADERS` is derived.
Add Copilot instructions for documentation.
Disable various markdownlint warnings.
@martincostello martincostello marked this pull request as ready for review July 22, 2025 09:59
@Copilot Copilot AI review requested due to automatic review settings July 22, 2025 09:59
@martincostello martincostello enabled auto-merge (squash) July 22, 2025 09:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the documentation by explaining how to construct the OTEL_EXPORTER_OTLP_HEADERS authentication token value. The change replaces a placeholder token with a more descriptive one and adds a detailed explanation of the base64 encoding process for Basic authentication with Grafana Cloud.

  • Clarifies that the Basic authentication token is a base64-encoded string
  • Adds comprehensive explanation with concrete example showing Instance ID and API key encoding
  • Improves user understanding of the authentication mechanism

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
README.md Updated authentication header example and added detailed explanation of base64 encoding process
.github/copilot-instructions.md Added comprehensive Grafana Labs documentation style guide and writing standards

Fix typos.

Co-authored-by: Copilot <[email protected]>
README.md Outdated
> The token for `Basic` authentication is the base64-encoded value of a Grafana
> Cloud Instance ID and an API key separated by a `:`.
>
> For example, if your Grafana Cloud Instance ID is `12345` and your API key is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API keys have been deprecated, replaced with with "service account tokens".

Exact naming is inconsistent depending on where you generate a token (service account token/API token/token/Grafana Cloud Access token/etc) but they are distinct from the older key based auth.

"service account token" not "API key".
@martincostello martincostello merged commit d418b5a into main Jul 24, 2025
17 checks passed
@martincostello martincostello deleted the clarify-auth branch July 24, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants