Enable deterministic builds #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
martincostello
force-pushed
the
deterministic-builds
branch
from
237c725 to
d92bbc2
Compare
- Enable deterministic builds for binaries/packages. - Centralise common settings in `Directory.Build.props`. - Refactor some MSBuild conditions to not need changing for .NET 9 and beyond.
Use .NET 8 Artifacts Output feature to put all build output in a central directory structure instead of in each project directory.
- Bump test NuGet packages to their latest versions and pin them. - Add GitHubActionsTestLogger.
- Remove "tests" and replace with "CI" with the intention to later add a job that can publish to NuGet.org. - Test on all three available operating systems in GitHub Actions. - Publish NuGet packages to GitHub Actions artifacts. - Add job to validate NuGet packages. - Attest artifacts. - Generate SBOM.
Update to the latest .NET 8 SDK to see if that fixes issue with missing source link information.
Fetch Git history.
Separate the runner name from the OS name.
Update MinVer to the latest stable version.
Include PDBs in NuGet packages.
Disable warning about stable packages depending on prerelease packages until all OpenTelemetry dependencies are stable.
Add a NuGet package README.
Point to `ci` not `unit-tests`.
martincostello
force-pushed
the
deterministic-builds
branch
from
aa0f41a to
270dccc
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables deterministic builds and centralizes build configuration while updating dependencies and CI workflows. Key changes include centralized properties via Directory.Build.props, refactored csproj files for updated target frameworks and package references, and revamped GitHub Actions workflows for CI and package validation.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Grafana.OpenTelemetry.Tests.csproj | Updated target frameworks and package reference versions. |
| src/Grafana.OpenTelemetry/Grafana.OpenTelemetry.csproj | Updated package references and adjusted conditional packaging. |
| src/Grafana.OpenTelemetry.Base/Grafana.OpenTelemetry.Base.csproj | Updated package references with conditional grouping. |
| package-readme.md | Added package README documentation. |
| global.json | Updated .NET SDK version. |
| README.md | Updated CI badges to reflect new workflow file. |
| Directory.Build.props | Centralized common build settings. |
| .github/workflows/unit-tests.yml | Removed outdated unit-tests workflow. |
| .github/workflows/ci.yml | Introduced a new CI workflow with build, test, and validation steps. |
matt-hensley
approved these changes
Jun 9, 2025
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Directory.Build.props.Merge requirement checklist
CHANGELOG.mdfile updated for non-trivial changes