Remove deprecated packages #146
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes a deprecated MySql instrumentation package and updates the WCF instrumentation package version.
- Replace deprecated OpenTelemetry.Instrumentation.MySqlData with MySql.Data.OpenTelemetry.
- Update OpenTelemetry.Instrumentation.Wcf from 1.0.0-rc.17 to 1.0.0-rc.18.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Grafana.OpenTelemetry/Grafana.OpenTelemetry.csproj | Removed deprecated MySql package reference and updated WCF package version. |
| CHANGELOG.md | Updated changelog entries to reflect the dependency changes. |
Comments suppressed due to low confidence (2)
src/Grafana.OpenTelemetry/Grafana.OpenTelemetry.csproj:32
- [nitpick] Consider clarifying this comment to indicate that the deprecated package reference has been replaced by MySql.Data.OpenTelemetry to help future readers understand the change.
<!-- OpenTelemetry.Instrumentation.MySqlData is deprecated -->
src/Grafana.OpenTelemetry/Grafana.OpenTelemetry.csproj:51
- Verify that version 1.0.0-rc.18 of OpenTelemetry.Instrumentation.Wcf is fully compatible with the rest of the instrumentation packages used in the project.
<PackageReference Include="OpenTelemetry.Instrumentation.Wcf" Version="1.0.0-rc.18" />
|
Going to use the PR as an opportunity to try out adding some licensing checks... |
Success:
|
|
|
- Remove `OpenTelemetry.Instrumentation.MySqlData`, which is deprecated, and recommend `MySql.Data.OpenTelemetry` instead. - Update OpenTelemetry.Instrumentation.Wcf to `1.0.0-rc.18`.
3 participants
Fixes #124
Changes
OpenTelemetry.Instrumentation.MySqlDatapackage.OpenTelemetry.Instrumentation.Wcfto1.0.0-rc.18.Merge requirement checklist
CHANGELOG.mdfile updated for non-trivial changes