Skip to content

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Jun 9, 2025

Fixes #124

Changes

  • Remove deprecated OpenTelemetry.Instrumentation.MySqlData package.
  • Update OpenTelemetry.Instrumentation.Wcf to 1.0.0-rc.18.

Merge requirement checklist

  • Unit tests added/updated
  • CHANGELOG.md file updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@martincostello martincostello marked this pull request as ready for review June 9, 2025 14:15
@Copilot Copilot AI review requested due to automatic review settings June 9, 2025 14:15
@martincostello martincostello requested a review from a team as a code owner June 9, 2025 14:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a deprecated MySql instrumentation package and updates the WCF instrumentation package version.

  • Replace deprecated OpenTelemetry.Instrumentation.MySqlData with MySql.Data.OpenTelemetry.
  • Update OpenTelemetry.Instrumentation.Wcf from 1.0.0-rc.17 to 1.0.0-rc.18.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Grafana.OpenTelemetry/Grafana.OpenTelemetry.csproj Removed deprecated MySql package reference and updated WCF package version.
CHANGELOG.md Updated changelog entries to reflect the dependency changes.
Comments suppressed due to low confidence (2)

src/Grafana.OpenTelemetry/Grafana.OpenTelemetry.csproj:32

  • [nitpick] Consider clarifying this comment to indicate that the deprecated package reference has been replaced by MySql.Data.OpenTelemetry to help future readers understand the change.
<!-- OpenTelemetry.Instrumentation.MySqlData is deprecated -->

src/Grafana.OpenTelemetry/Grafana.OpenTelemetry.csproj:51

  • Verify that version 1.0.0-rc.18 of OpenTelemetry.Instrumentation.Wcf is fully compatible with the rest of the instrumentation packages used in the project.
<PackageReference Include="OpenTelemetry.Instrumentation.Wcf" Version="1.0.0-rc.18" />

@martincostello
Copy link
Member Author

Going to use the PR as an opportunity to try out adding some licensing checks...

@martincostello
Copy link
Member Author

Going to use the PR as an opportunity to try out adding some licensing checks...

Success:

The following dependencies have incompatible licenses:
src/Grafana.OpenTelemetry/Grafana.OpenTelemetry.csproj » [email protected] – License: GPL-2.0-only WITH Universal-FOSS-exception-1.0
Error: Dependency review detected incompatible licenses.

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2025

CLA assistant check
All committers have signed the CLA.

- Remove `OpenTelemetry.Instrumentation.MySqlData`, which is deprecated, and recommend `MySql.Data.OpenTelemetry` instead.
- Update OpenTelemetry.Instrumentation.Wcf to `1.0.0-rc.18`.
@martincostello martincostello merged commit 0e65f59 into main Jul 11, 2025
14 checks passed
@martincostello martincostello deleted the gh-124 branch July 11, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usage of deprecated Opentelemetry Packages

3 participants