Skip to content

Conversation

martincostello
Copy link
Member

Changes

Add a GitHub Actions workflow that checks the licenses of dependencies, amongst other things.

Once merged, if I rebase #146 it should detect the incompatible license.

Merge requirement checklist

  • Unit tests added/updated
  • CHANGELOG.md file updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Add a GitHub Actions workflow that checks the licenses of dependencies, amongst other things.
@martincostello martincostello marked this pull request as ready for review June 11, 2025 12:42
@Copilot Copilot AI review requested due to automatic review settings June 11, 2025 12:42
@martincostello martincostello requested a review from a team as a code owner June 11, 2025 12:42
@martincostello martincostello enabled auto-merge (squash) June 11, 2025 12:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub Actions workflow to perform dependency license reviews, ensuring that only dependencies with approved licenses are used.

  • Introduces a new workflow file for dependency review triggered on pull requests to the main branch
  • Configures the checkout and dependency-review steps with pinned versions for reproducibility
Comments suppressed due to low confidence (1)

.github/workflows/dependency-review.yml:7

  • [nitpick] Consider adding a comment clarifying the intent behind the empty global permissions block to help future maintainers understand that this is intentional for reducing the workflow's access scope.
permissions: {}

Copy link
Contributor

@matt-hensley matt-hensley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring OATs warning for now

@martincostello
Copy link
Member Author

Ignoring OATs warning for now

Yeah, I'll look into this later. Maybe it also explains why I was unexpectedly getting failures in #150 too.

@matt-hensley matt-hensley disabled auto-merge June 11, 2025 13:49
Pin to the .NET 8.0.410 SDK to see if any updates for 8.0.411 broke things.
Use HTTPS to `postman-echo.com` to avoid an HTTP 301 redirect.
@martincostello martincostello merged commit d95982f into main Jun 12, 2025
13 checks passed
@martincostello martincostello deleted the dependency-checks branch June 12, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants