Refactor SBOM generation #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only generate on Windows (as that's the "chosen one" for publishing). - Rename to `grafana-opentelemetry-dotnet.spdx.json`.
There was a problem hiding this comment.
Pull Request Overview
The PR refactors the SBOM generation step to only run on Windows and standardizes the SBOM filename.
- Adds a step-level
ifcondition to restrict SBOM creation to Windows runners - Renames the SBOM artifact and output file to
grafana-opentelemetry-dotnet.spdx.json - Simplifies
upload-release-assetsto always be true (now that generation is Windows-only)
matt-hensley
approved these changes
Jun 30, 2025
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
grafana-opentelemetry-dotnet.spdx.json.Merge requirement checklist
CHANGELOG.mdfile updated for non-trivial changes