-
Notifications
You must be signed in to change notification settings - Fork 9
Verify AWS instrumentation in OATS #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the OATS tests to assert on AWS SDK traces using LocalStack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Extend the OATS test suite and example ASP.NET Core application to verify AWS S3 SDK instrumentation via LocalStack.
- Added AWSSDK.S3 package and S3 client registration in the example app
- Introduced
AwsController
to list S3 buckets - Updated OATS scenarios, Docker Compose configs, and Renovate rules for LocalStack support
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
examples/net8.0/aspnetcore/aspnetcore.csproj | Added AWSSDK.S3 reference to enable S3 instrumentation |
examples/net8.0/aspnetcore/Program.cs | Registered AmazonS3Client service |
examples/net8.0/aspnetcore/Controllers/AwsController.cs | New controller to list S3 buckets |
docker/docker-compose-aspnetcore/oats.yaml | Added OATS path and expected S3 ListBuckets trace assertion |
docker/docker-compose-aspnetcore/docker-compose.yml | Configured AWS env vars and added LocalStack service |
docker/docker-compose-aspnetcore/docker-compose.self-contained.oats.yml | Configured AWS env vars and added LocalStack for self-contained |
docker/docker-compose-aspnetcore/docker-compose.oats.yml | Configured AWS env vars and added LocalStack |
.github/renovate.json | Added scheduled and version rules for AWS SDK updates |
Comments suppressed due to low confidence (1)
examples/net8.0/aspnetcore/Controllers/AwsController.cs:13
- [nitpick] The constructor parameter
client
is ambiguous—consider renaming tos3Client
oramazonS3Client
for clarity.
public class AwsController(AmazonS3Client client, ILogger<AwsController> logger) : ControllerBase
- Use `IAmazonS3`. - Fix incorrect log message.
matt-hensley
approved these changes
Jun 30, 2025
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
docker
Pull requests that update docker code
enhancement
New feature or request
.NET
Pull requests that update .NET code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the OATS tests to assert on AWS SDK traces using LocalStack.
Fixes #147
Changes
Use LocalStack to verify instrumentation for AWS is enabled by the distro.
Merge requirement checklist
CHANGELOG.md
file updated for non-trivial changesChanges in public API reviewed (if applicable)