Skip to content

Conversation

martincostello
Copy link
Member

Extend the OATS tests to assert on AWS SDK traces using LocalStack.

Fixes #147

Changes

Use LocalStack to verify instrumentation for AWS is enabled by the distro.

Merge requirement checklist

  • Unit tests added/updated
  • CHANGELOG.md file updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Extend the OATS tests to assert on AWS SDK traces using LocalStack.
@martincostello martincostello added enhancement New feature or request .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file docker Pull requests that update docker code labels Jun 25, 2025
Fix URL after refactor.
@martincostello martincostello marked this pull request as ready for review June 25, 2025 12:08
@Copilot Copilot AI review requested due to automatic review settings June 25, 2025 12:08
@martincostello martincostello requested a review from a team as a code owner June 25, 2025 12:08
@martincostello martincostello enabled auto-merge (squash) June 25, 2025 12:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Extend the OATS test suite and example ASP.NET Core application to verify AWS S3 SDK instrumentation via LocalStack.

  • Added AWSSDK.S3 package and S3 client registration in the example app
  • Introduced AwsController to list S3 buckets
  • Updated OATS scenarios, Docker Compose configs, and Renovate rules for LocalStack support

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
examples/net8.0/aspnetcore/aspnetcore.csproj Added AWSSDK.S3 reference to enable S3 instrumentation
examples/net8.0/aspnetcore/Program.cs Registered AmazonS3Client service
examples/net8.0/aspnetcore/Controllers/AwsController.cs New controller to list S3 buckets
docker/docker-compose-aspnetcore/oats.yaml Added OATS path and expected S3 ListBuckets trace assertion
docker/docker-compose-aspnetcore/docker-compose.yml Configured AWS env vars and added LocalStack service
docker/docker-compose-aspnetcore/docker-compose.self-contained.oats.yml Configured AWS env vars and added LocalStack for self-contained
docker/docker-compose-aspnetcore/docker-compose.oats.yml Configured AWS env vars and added LocalStack
.github/renovate.json Added scheduled and version rules for AWS SDK updates
Comments suppressed due to low confidence (1)

examples/net8.0/aspnetcore/Controllers/AwsController.cs:13

  • [nitpick] The constructor parameter client is ambiguous—consider renaming to s3Client or amazonS3Client for clarity.
public class AwsController(AmazonS3Client client, ILogger<AwsController> logger) : ControllerBase

- Use `IAmazonS3`.
- Fix incorrect log message.
@martincostello martincostello merged commit 59fef3b into main Jun 30, 2025
13 checks passed
@martincostello martincostello deleted the gh-147 branch June 30, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file docker Pull requests that update docker code enhancement New feature or request .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add AWS to OATS tests

2 participants