Update OATS metrics #204
Merged
Update OATS metrics #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Require 1 or more, rather than zero or more. - Add `http_server_request_duration_seconds_count`.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the OATS (OpenTelemetry Acceptance Test Suite) configuration to improve test reliability by requiring actual metric generation rather than just checking for metric existence. The changes ensure that HTTP client and server metrics are actually being recorded during tests.
- Updates metric value assertions from
>= 0to>= 1to require actual requests - Adds a new metric check for HTTP server request duration count
matt-hensley
approved these changes
Jul 29, 2025
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
http_server_request_duration_seconds_count.Merge requirement checklist
CHANGELOG.mdupdatedChanges in public API reviewed (if applicable)