Skip to content

Conversation

martincostello
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings September 23, 2025 13:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR attempts to reproduce an OpenTelemetry .NET issue by modifying Docker configuration for a .NET 8.0 ASP.NET Core example. The changes focus on creating a self-contained deployment setup that may help isolate the reported issue.

Key changes:

  • Modified Docker build to use self-contained deployment with runtime-only base image
  • Updated Docker Compose configuration to avoid duplicate self-contained flags
  • Added security improvement with non-root user execution

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
examples/net8.0/aspnetcore/Dockerfile Updated to use self-contained deployment and runtime-only base image, added non-root user
docker/docker-compose-aspnetcore/docker-compose.self-contained.oats.yml Removed duplicate --self-contained flag from publish arguments

Disable invariance to fix errors from SQL.(?).
Add ICU libraries.
@Copilot Copilot AI review requested due to automatic review settings September 23, 2025 13:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant