Skip to content

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Oct 10, 2025

Changes

  • Use Meziantou.Framework.NuGetPackageValidation.Tool to extend NuGet package validation.
  • Include XML documentation in NuGet packages.
  • Fix incorrect XML documentation references.

Merge requirement checklist

  • Unit tests added/updated
  • CHANGELOG.md updated
  • Changes in public API reviewed (if applicable)

Use Meziantou.Framework.NuGetPackageValidation.Tool to extend NuGet package validation.
@Copilot Copilot AI review requested due to automatic review settings October 10, 2025 11:14
@martincostello martincostello added enhancement New feature or request .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Oct 10, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request extends NuGet package validation by adding the Meziantou.Framework.NuGetPackageValidation.Tool as an additional validation layer alongside the existing dotnet-validate tool.

Key changes:

  • Adds Meziantou NuGet package validation tool to the CI pipeline
  • Integrates both validation tools into a single workflow step
  • Updates the validation logic to track failures from both tools

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/ci.yml Adds Meziantou tool installation, updates validation step to run both tools, and modifies failure tracking logic
.config/dotnet-tools.json Defines the Meziantou NuGet package validation tool dependency

- Include XML documentation in NuGet packages.
- Fix incorrect XML documentation references.
@martincostello martincostello added the bug Something isn't working label Oct 10, 2025
@martincostello martincostello marked this pull request as ready for review October 10, 2025 11:51
@martincostello martincostello requested a review from a team as a code owner October 10, 2025 11:51
@Copilot Copilot AI review requested due to automatic review settings October 10, 2025 11:51
@martincostello martincostello enabled auto-merge (squash) October 10, 2025 11:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant