chore: call getFolderUID once before looping instances #2129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
force-pushed
the
chore_call_getfolderuid_once
branch
from
386c675 to
b05453a
Compare
Baarsgaard
force-pushed
the
chore_call_getfolderuid_once
branch
from
b05453a to
5bb1b42
Compare
Baarsgaard
requested review from
nissessenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
weisdd
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in a few controllers
getFolderUIDis called once per instance rather than once overall.Moved getFolderUID before the main synchronize loop in relevant controllers which gives a few benefits
folderonce per reconcile.