Threshold: Fix JSON marshal/unmarshal thresholds with NaN and zero values#1497
Merged
Threshold: Fix JSON marshal/unmarshal thresholds with NaN and zero values#1497
Conversation
ryantxu
commented
Feb 28, 2026
|
|
||
| // Threshold a single step on the threshold list | ||
| type Threshold struct { | ||
| Value ConfFloat64 `json:"value,omitempty"` // First value is always -Infinity serialize to null |
Contributor
Author
There was a problem hiding this comment.
omit empty was dropping zero -- and then it woudl come back as -inf
ryantxu
commented
Feb 28, 2026
| math.IsNaN(float64(*sf)) || | ||
| math.IsInf(float64(*sf), -1) || | ||
| math.IsInf(float64(*sf), +1) { | ||
| func (sf ConfFloat64) MarshalJSON() ([]byte, error) { |
Contributor
Author
There was a problem hiding this comment.
switched from pointer receiver to value reciever -- the logic was skipped for Thresholds because they are not pointers 🤦🏻
ryantxu
commented
Feb 28, 2026
data/field_config_test.go
Outdated
| out, err := json.Marshal([]data.Threshold{tc.before}) | ||
| require.NoError(t, err) | ||
|
|
||
| arr := []data.Threshold{} |
Contributor
Author
There was a problem hiding this comment.
@roosenj -- this test replicates your issue (i think!)
There was a problem hiding this comment.
Great, thanks for looking into this again! I notice you're testing with the builtin encoding/json, from what I saw the SDK uses json-iterator/go instead as its JSON parser, is the marshaling logic for these two libraries the same?
Contributor
Author
There was a problem hiding this comment.
i updated the test for both json.Marshal and jsoniter.Marshal
grafana-plugins-platform-bot
bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
github-project-automation
bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1447, #1496 and #1466