Skip node_modules directory in manifest generation#1504
Merged
Conversation
Exclude Go files located in the node_modules directory from the plugin manifest file generated during the build process. This prevents frontend dependencies from being included in the backend plugin manifest. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
|
Restrict the node_modules exclusion to the root directory only so that Go files in nested node_modules directories are still included. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add writeFile and mkdirAll test helpers that check error return values, and handle the os.Chdir error in the cleanup function. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use 0600 for file permissions and 0750 for directory permissions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
academo
approved these changes
Mar 11, 2026
andresmgot
approved these changes
Mar 11, 2026
Contributor
There was a problem hiding this comment.
Requested to re-enable the CLA assistant here.
Edit: You need to sign the CLA yourself
Contributor
Author
Thanks for the ping 🙏🏻 I have sign this before for this repo but seems like I needed to sign it again. |
github-project-automation
bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Excludes Go files located in the
node_modulesdirectory from the plugin manifest file generated during the build process. This prevents frontend dependencies from being included in the backend plugin manifest, which is important for plugins that have both frontend and backend components.This fix validation errors produced when plugin has a frontend dependency on a package containing
.gofiles.Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
All existing tests continue to pass and new tests verify the
node_modulesdirectory is properly excluded from the manifest.