[tempo-distributed] Fixing Tempo Registry Colcase Order #3821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portswigger-amason
requested review from
Sheikh-Abubaker,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
|
|
portswigger-amason
changed the title
portswigger-amason
force-pushed
the
fix/tempo-distributed-registry-colcase
branch
from
74587cb to
a27d9d5
Compare
|
Could I please get some help in getting this merged. I would like to roll out the changes. |
|
@Sheikh-Abubaker Apologies for the ping, could you help me with an approval? |
Problem: Component-specific registry overrides weren't working despite being documented as overriding global registry.
Root Cause: Template helper function had incorrect priority order in coalesce:
`{{- $registry := coalesce .global.registry .component.registry .tempo.registry -}}`
Fix: Changed priority to put component registry first:
`{{- $registry := coalesce .component.registry .tempo.registry .global.registry -}}``
Result:
- Component registry now properly overrides global registry as documented
- Fully backwards compatible - when component registry is null, falls back to global
- Enables clean configuration like memcached.image.registry: public.ecr.aws
Signed-off-by: portswigger-amason <[email protected]>
Signed-off-by: portswigger-amason <[email protected]>
portswigger-amason
force-pushed
the
fix/tempo-distributed-registry-colcase
branch
from
c1a67fb to
80c6f5c
Compare
Signed-off-by: portswigger-amason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Component-specific registry overrides weren't working despite being documented as overriding global registry.
Root Cause: Template helper function had incorrect priority order in coalesce:
{{- $registry := coalesce .global.registry .component.registry .tempo.registry -}}Fix: Changed priority to put component registry first:
`{{- $registry := coalesce .component.registry .tempo.registry .global.registry -}}``
Result: