[tempo-distributed] Pass Namespace to Tempo Autoscaling #3826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msgSend
requested review from
Sheikh-Abubaker,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
|
|
Signed-off-by: Erwin Tung <[email protected]>
Signed-off-by: Erwin Tung <[email protected]>
Signed-off-by: Erwin Tung <[email protected]>
Signed-off-by: Erwin Tung <[email protected]>
Signed-off-by: Erwin Tung <[email protected]>
msgSend
force-pushed
the
tempo_autoscale_namespace
branch
from
ca81c45 to
d9b4991
Compare
Signed-off-by: Erwin Tung <[email protected]>
Signed-off-by: Erwin Tung <[email protected]>
msgSend
force-pushed
the
tempo_autoscale_namespace
branch
from
97a4cc3 to
ca93300
Compare
|
Is there anything else needed from my end to get this PR over the finish line? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the Tempo HPA templates are missing namespace attributes in the metadata which causes them to be deployed in the wrong namespace if Helm isn't used to directly install it into the desired namespace.
This just adds the namespace to all of them so that they will show up in the manifests.