Feat: make tempo memberlist parameter configurable #3952
+45
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paranoiasystem
requested review from
a team,
BitProcessor,
QuentinBisson,
Sheikh-Abubaker,
faustodavid and
swartz-k
as code owners
|
|
Signed-off-by: Marco Ferraioli <[email protected]>
Signed-off-by: Marco Ferraioli <[email protected]>
paranoiasystem
force-pushed
the
feat/make-tempo-memberlist-configurable
branch
from
b06ec01 to
7073ee7
Compare
Signed-off-by: Marco Ferraioli <[email protected]>
paranoiasystem
force-pushed
the
feat/make-tempo-memberlist-configurable
branch
from
7e78989 to
87e3404
Compare
|
@paranoiasystem could you please resolve the conflicts, check why linting failed and only do the change you need and not change all the quotes? This makes the review a lot harder ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I needed to specify a custom join_members field in my Tempo configuration, similar to how it works in Loki.
I tried several approaches, but I noticed an issue in the template that completely overwrites the configuration from values.yaml.
So, I implemented a fix: now, if you provide a join_members array, it will be applied to the configuration; otherwise, the template generates the default value as before.