Skip to content

Conversation

@jkroepke
Copy link
Collaborator

@jkroepke jkroepke commented Nov 1, 2025

No description provided.

@jkroepke jkroepke marked this pull request as ready for review November 1, 2025 20:42
@jkroepke jkroepke requested a review from a team as a code owner November 1, 2025 20:42
@jkroepke
Copy link
Collaborator Author

jkroepke commented Nov 1, 2025

The chart never works, the minio version seems never exists,

@jkroepke
Copy link
Collaborator Author

jkroepke commented Nov 2, 2025

@zalegrala I may need your assistance here, because the chart is broken anyways (due invalid dependencies), I cant merge this.

@zalegrala
Copy link
Contributor

Hmm, I can't force-merge this either with the failing CI. So to deprecate it, do we need to fix the dependencies here?

@Sheikh-Abubaker
Copy link
Collaborator

Sheikh-Abubaker commented Nov 3, 2025

@jkroepke what if we remove the minio dependency completely or set the version to something that actually exists ? anyways the chart is being deprecated so I don't really think it matters ?

@jkroepke
Copy link
Collaborator Author

jkroepke commented Nov 3, 2025

Maybe @dehaansa can help here.

(ref #3982)

@dehaansa
Copy link
Contributor

dehaansa commented Nov 3, 2025

Maybe @dehaansa can help here.

(ref #3982)

I'm not confident enough to merge this myself (though it makes sense to me!), but I'll try to get some eyes on it.

Oops, doing this on mobile I missed some context, I can't merge with the failing tests either.

@Sheikh-Abubaker
Copy link
Collaborator

@jkroepke the tempo-distributed chart also includes minio (the version that actually exists) as one of its dependency, how about if could you try with the same version here in order to pass CI check:

dependencies:
- name: minio
alias: minio
version: 4.0.12
repository: https://charts.min.io/
condition: minio.enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants