Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
index.json
Outdated
| "type": "docs-page", | ||
| "match": { | ||
| "and": [ | ||
| { "urlPrefix": "/" } |
There was a problem hiding this comment.
Add:
{ "source": "(stack1|stack2|localhost|oss-source)" }
It's fine that your URL prefix match is overly broad (we're in dev) but this is the spot where you do need to limit a dev guide to only stacks of interest. If I merged this as is, the dev guide would go out to play too
|
I've successfully run through this using a local OSS Grafana stack. One thing I'd note is that it refers people to administrative sections of the UI. Do we have the ability to only show those steps if the user's got admin rights @moxious ? |
4 participants
I'm adding this as a way to get used to how these work. This will be a draft PR / work in progress.
TODO List:
data-requirements="is-admin"guards are in place.