Cilium clustermesh alerts #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dasomeone
requested changes
Oct 22, 2024
Member
Dasomeone
left a comment
Dasomeone
left a comment
There was a problem hiding this comment.
Hi @balous, thanks for another contribution to this mixin, and apologies for the delay in getting a response :)
We've recently been working on moving over our linting from Drone CI to Github Actions and it appears a few steps are no longer included, so I've manually ran the linting for this change which highlighted a few issues that need to be addressed.
If you want to reproduce, you can install mixtool yourself and run mixtool lint mixin.libsonnet
mixtool lint mixin.libsonnet
[alert-severity-rule] Alert 'CiliumAgentRemoteClusterNotReady' severity must be 'warning', 'critical' or 'info', is currently 'high'
[alert-description-missing-rule] Alert 'CiliumAgentRemoteClusterNotReady' must have annotation 'description'
[alert-summary-templating] Alert CiliumAgentRemoteClusterNotReady annotation 'summary' must not use templates
[alert-summary-style] Alert CiliumAgentRemoteClusterNotReady annotation 'summary' must start with capital letter and end with period, is currently 'Agent can't mesh with {{$labels.target_cluster}}'
[alert-severity-rule] Alert 'CiliumAgentRemoteClusterFailing' severity must be 'warning', 'critical' or 'info', is currently 'high'
[alert-description-missing-rule] Alert 'CiliumAgentRemoteClusterFailing' must have annotation 'description'
[alert-summary-templating] Alert CiliumAgentRemoteClusterFailing annotation 'summary' must not use templates
[alert-summary-style] Alert CiliumAgentRemoteClusterFailing annotation 'summary' must start with capital letter and end with period, is currently 'Agent fails to mesh with {{$labels.target_cluster}}'
[alert-severity-rule] Alert 'CiliumKvstoremeshRemoteClusterNotReady' severity must be 'warning', 'critical' or 'info', is currently 'high'
[alert-description-missing-rule] Alert 'CiliumKvstoremeshRemoteClusterNotReady' must have annotation 'description'
[alert-summary-templating] Alert CiliumKvstoremeshRemoteClusterNotReady annotation 'summary' must not use templates
[alert-summary-style] Alert CiliumKvstoremeshRemoteClusterNotReady annotation 'summary' must start with capital letter and end with period, is currently 'Kvstoremesh can't mesh with {{$labels.target_cluster}}'
[alert-severity-rule] Alert 'CiliumKvstoremeshRemoteClusterFailing' severity must be 'warning', 'critical' or 'info', is currently 'high'
[alert-description-missing-rule] Alert 'CiliumKvstoremeshRemoteClusterFailing' must have annotation 'description'
[alert-summary-templating] Alert CiliumKvstoremeshRemoteClusterFailing annotation 'summary' must not use templates
[alert-summary-style] Alert CiliumKvstoremeshRemoteClusterFailing annotation 'summary' must start with capital letter and end with period, is currently 'Kvstoremesh fails to mesh with {{$labels.target_cluster}}'
[alert-severity-rule] Alert 'CiliumKvstoremeshErrors' severity must be 'warning', 'critical' or 'info', is currently 'high'
[alert-description-missing-rule] Alert 'CiliumKvstoremeshErrors' must have annotation 'description'
[alert-summary-templating] Alert CiliumKvstoremeshErrors annotation 'summary' must not use templates
[alert-summary-style] Alert CiliumKvstoremeshErrors annotation 'summary' must start with capital letter and end with period, is currently 'Kvstoremesh fails to mesh with {{$labels.target_cluster}}'
2024/10/22 13:04:14 failed to lint the file mixin.libsonnet: 20 lint errors found
balous
force-pushed
the
cilium-clustermesh
branch
from
4a5cb40 to
f44fd44
Compare
Contributor
Author
|
Fixed. |
Dasomeone
approved these changes
Oct 23, 2024
Member
Dasomeone
left a comment
Dasomeone
left a comment
There was a problem hiding this comment.
Awesome, thanks for making the changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two groups of rules: