Skip to content

Fix 'mixtool lint' in commonlib/logslib #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
v-zhuravlev merged 1 commit into from
Dec 9, 2024
Merged

Fix 'mixtool lint' in commonlib/logslib #1366

v-zhuravlev merged 1 commit into from
Dec 9, 2024

Conversation

@v-zhuravlev
Copy link
Contributor

@v-zhuravlev v-zhuravlev commented Dec 9, 2024

This should fix the following mixtool lint warnings:

[target-logql-auto-rule] 'Windows logs': Dashboard 'Windows logs', panel 'Logs volume', target idx '0' LogQL query uses fixed duration: should use $__auto

and

[template-datasource-rule] 'Windows fleet overview': Dashboard 'Windows fleet overview' templated data source variable labeled 'Prometheus datasource', should be labeled 'Prometheus data source'

@v-zhuravlev v-zhuravlev requested a review from a team as a code owner December 9, 2024 16:21
@v-zhuravlev v-zhuravlev merged commit 8788838 into master Dec 9, 2024
4 checks passed
@v-zhuravlev v-zhuravlev deleted the commonlib_lint_fix branch December 9, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgeyer rgeyer rgeyer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v-zhuravlev @rgeyer