Mixin lint fixes

common-lib/common/signal/utils.libsonnet

@@ -53,7 +53,6 @@
         if unit == 'seconds' || unit == 's' then 'percent'
         else if unit == 'requests' then 'rps'
         else if unit == 'packets' then 'pps'
-        else if unit == 'short' then '/s'
         else unit
       )
     else unit,

jvm-observ-lib/.lint

@@ -1,13 +1,8 @@
 exclusions:
-  panel-title-description-rule:
-    reason: "mixtool upgrade made this rule stricter. TODO: Fix errors and remove the warning exclusion"
+  panel-datasource-rule:
+    entries:
+      - panel: GC duration
+      - panel: Allocated/promoted
   panel-units-rule:
-    reason: "mixtool upgrade made this rule stricter. TODO: Fix errors and remove the warning exclusion"
-  template-datasource-rule:
-    reason: "mixtool upgrade made this rule stricter. TODO: Fix errors and remove the warning exclusion"
-  template-instance-rule:
-    reason: "mixtool upgrade made this rule stricter. TODO: Fix errors and remove the warning exclusion"
-  template-job-rule:
-    reason: "mixtool upgrade made this rule stricter. TODO: Fix errors and remove the warning exclusion"
-  template-on-time-change-reload-rule:
-    reason: "mixtool upgrade made this rule stricter. TODO: Fix errors and remove the warning exclusion"
+    entries:
+      - panel: Process files open

jvm-observ-lib/panels.libsonnet

@@ -71,6 +71,7 @@ local commonlib = import 'common-lib/common/main.libsonnet';
 
     gcDuration:
       g.panel.timeSeries.new('GC duration')
+      + g.panel.timeSeries.panelOptions.withDescription('Major and minor garbage collections')
       + commonlib.panels.generic.timeSeries.base.stylize()
       + g.panel.timeSeries.fieldConfig.defaults.custom.withFillOpacity(0)
       + signals.gc.collectionsTimeAvg.asPanelMixin()
@@ -79,6 +80,12 @@ local commonlib = import 'common-lib/common/main.libsonnet';
 
     promotedAllocated:
       g.panel.timeSeries.new('Allocated/promoted')
+      + g.panel.timeSeries.panelOptions.withDescription(
+        |||
+          'Allocated' is the size increase of the young generation memory pool after one GC and before the next. It reflects minor GC.
+          'Promoted' is the size increase of the old generation memory pool after GC. It reflects full GC.
+        |||
+      )
       + commonlib.panels.memory.timeSeries.usageBytes.stylize()
       + signals.gc.memAllocatedBytes.asPanelMixin()
       + signals.gc.memAllocated.asPanelMixin()

jvm-observ-lib/signals/gc.libsonnet

@@ -22,7 +22,7 @@ function(this)
       //gc
       collections: {
         name: 'Garbage collections',
-        description: 'Major and minor garbage collection',
+        description: 'Major and minor garbage collections',
         type: 'counter',
         unit: 'ops',
         optional: true,

kafka-observ-lib/.lint

@@ -0,0 +1,70 @@
+exclusions:
+  panel-units-rule:
+    entries:
+      - panel: Process files open
+
+  target-instance-rule:
+    reason: Instance selector is intentionally dropped in these panels as they represent whole cluster.
+    entries:
+      - dashboard: ZooKeeper overview
+        panel: Current zookeeper role
+      - dashboard: Kafka overview
+        panel: Current role
+      - dashboard: Kafka overview
+        panel: Active kafka controllers
+      - dashboard: Kafka overview
+        panel: Brokers count
+      - dashboard: Kafka overview
+        panel: Brokers count
+      - dashboard: Kafka overview
+        panel: Cluster network throughput
+      - dashboard: Kafka overview
+        panel: Cluster messages throughput
+      - dashboard: Kafka topic overview
+  panel-datasource-rule:
+    entries:
+      - panel: GC duration
+      - panel: Allocated/promoted
+      - panel: Cluster network throughput
+      - panel: Cluster messages throughpu
+      - panel: Broker network throughput
+      - panel: Broker messages throughput
+      - panel: Producer ($instance)
+      - panel: Fetch-follower ($instance)
+      - panel: Fetch-consumer ($instance)
+      - panel: Cluster network throughput
+        dashboard: Kafka overview
+      - panel: Cluster messages throughput
+        dashboard: Kafka overview
+      - panel: Broker network throughput
+        dashboard: Kafka overview
+      - panel: Broker messages throughput
+        dashboard: Kafka overview
+      - panel: Consumer group overview
+        dashboard: Kafka topic overview
+      - panel: Topic overview
+        dashboard: Kafka topic overview
+
+  panel-title-description-rule:
+    entries:
+      - panel: Cluster network throughput
+        dashboard: Kafka overview
+      - panel: Cluster messages throughput
+        dashboard: Kafka overview
+      - panel: Broker network throughput
+        dashboard: Kafka overview
+      - panel: Broker messages throughput
+        dashboard: Kafka overview
+      - panel: Consumer group overview
+        dashboard: Kafka topic overview
+  template-instance-rule:
+    reason: kafka_cluster is used intead
+    entries:
+      - dashboard: Kafka topic overview
+
+  target-job-rule:
+    reason: kafka_cluster is used intead
+  template-job-rule:
+    reason: kafka_cluster is used intead
+
+

kafka-observ-lib/panels/topic.libsonnet

@@ -15,6 +15,7 @@ local commonlib = import 'common-lib/common/main.libsonnet';
     // Requirements for this table's data
     topicTable:
       signals.topic.topicLogStartOffset.asTable(name='Topic overview', format='time_series')
+      + g.panel.table.panelOptions.withDescription('Kafka active topics overview. ')
       + signals.topic.topicLogEndOffset.asTableColumn(format='time_series')
       + signals.topic.topicMessagesPerSecByPartition.asTableColumn(format='time_series')
       + signals.topic.topicLogSize.asTableColumn(format='time_series')

memcached-mixin/dashboards.libsonnet

@@ -118,6 +118,7 @@ local g = (import 'grafana-builder/grafana.libsonnet');
             'Value #B': { alias: 'Uptime', type: 'number', unit: 'dtdurations' },
           })
         )
-      ),
+      )
+      { editable: false },
   },
 }

process-observ-lib/.lint

@@ -0,0 +1,4 @@
+exclusions:
+  panel-units-rule:
+    entries:
+      - panel: Process files open

windows-mixin/.lint

@@ -1,17 +1,11 @@
 exclusions:
   panel-units-rule:
-    reason: "mixtool upgrade made this rule stricter. TODO: Fix errors and remove the warning exclusion"
-  template-datasource-rule:
-    reason: "Based on new convention we are using variable names prometheus_datasource and loki_datasource where as linter expects 'datasource'"
+    entries:
+      - panel: Disk average queue
+      - panel: CPU count
   template-instance-rule:
-    reason: "mixtool upgrade made this rule stricter. TODO: Fix errors and remove the warning exclusion"
-  template-on-time-change-reload-rule:
-    reason: "mixtool upgrade made this rule stricter. TODO: Fix errors and remove the warning exclusion"
-  target-instance-rule:
-    reason: "Failing with new dashboard linter. TODO: Investigate and remove the warning exclusion"
-  target-job-rule:
-    reason: "mixtool upgrade made this rule stricter. TODO: Fix errors and remove the warning exclusion"
-  target-promql-rule:
-    reason: "Linter does not support all LogQL queries and gives ivalid PromQL query error"
+    reason: "These dashboards are designed to be single instance"
     entries:
-      - dashboard: "Windows logs"
+      - dashboard: Windows overview
+      - dashboard: Windows CPU and system
+      - dashboard: Windows disks and filesystems

windows-observ-lib/.lint

@@ -0,0 +1,11 @@
+exclusions:
+  panel-units-rule:
+    entries:
+      - panel: Disk average queue
+      - panel: CPU count
+  template-instance-rule:
+    reason: "These dashboards are designed to be single instance"
+    entries:
+      - dashboard: Windows overview
+      - dashboard: Windows CPU and system
+      - dashboard: Windows disks and filesystems

zookeeper-observ-lib/.lint

@@ -0,0 +1,13 @@
+exclusions:
+  panel-units-rule:
+    entries:
+      - panel: Process files open
+  panel-datasource-rule:
+    entries:
+      - panel: GC duration
+      - panel: Allocated/promoted
+  target-instance-rule:
+    reason: Instance selector is intentionally dropped in these panels as they represent whole cluster.
+    entries:
+      - dashboard: ZooKeeper overview
+        panel: Current zookeeper role

zookeeper-observ-lib/config.libsonnet

@@ -1,7 +1,7 @@
 {
   local this = self,
   filteringSelector: 'job!=""',
-  groupLabels: ['cluster'],
+  groupLabels: ['job'],
   instanceLabels: ['instance'],
   uid: 'zookeeper',
   dashboardNamePrefix: '',