chore: Modernize squid-mixin #1526
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
postnati
changed the title
postnati
changed the title
schmikei
requested changes
Nov 3, 2025
Contributor
schmikei
left a comment
schmikei
left a comment
There was a problem hiding this comment.
Looking closer! Think I've caught a couple things that we should fix though. Will sync up with you async on these
postnati
force-pushed
the
chore/squid-mixin-modernization
branch
from
28ada05 to
f364f66
Compare
Author
|
Screenshots Overview Dashboard
Logs Dashboard
|
schmikei
requested changes
Nov 25, 2025
Contributor
schmikei
left a comment
schmikei
left a comment
There was a problem hiding this comment.
Not much is standing out to myself aside from maybe looking at avoiding complications with manual x,y setting via the g.util.grid.wrapPanels function in dashboards.libsonnet
Nice work!
| clientRow: | ||
| g.panel.row.new('Client') | ||
| + g.panel.row.withPanels([ | ||
| panels.clientRequests { gridPos: { h: 8, w: 8, x: 0, y: 1 } }, |
Contributor
There was a problem hiding this comment.
Not sure we need to specify x,y in this case and probably should use g.util.wrapPanels within dashboards.libsonnet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the squid-mixin to use grafonnet v11 and the signals architecture pattern.