chore: Modernize wildfly-mixin #1535
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
postnati
changed the title
postnati
force-pushed
the
chore/wildfly-mixin-modernization
branch
2 times, most recently
from
6cd1b59 to
216eb64
Compare
… counter type and range increase.
postnati
force-pushed
the
chore/wildfly-mixin-modernization
branch
from
d357bd6 to
1c13b3b
Compare
Author
|
Screenshots Overview Dashboard
Datasource Dashboard
Logs Dashboard
|
schmikei
requested changes
Nov 25, 2025
Contributor
schmikei
left a comment
schmikei
left a comment
There was a problem hiding this comment.
This is looking really good to me aside from one thing with the config.libsonnet
| alertsErrorRequestErrorRate: '30', | ||
| alertsErrorRejectedSessions: '20', | ||
| uid: 'wildfly', | ||
| dashboardTags: [self.uid], |
Contributor
There was a problem hiding this comment.
Suggested change
| dashboardTags: [self.uid], | |
| dashboardTags: [self.uid+-'mixin'], |
This'd be a breaking default otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the wildfly-mixin to use grafonnet v11 and the signals architecture pattern.