-
Notifications
You must be signed in to change notification settings - Fork 238
binary provisioning: GA updates #1994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
1 similar comment
|
5dfbac4
to
e73a768
Compare
Signed-off-by: Pablo Chacin <[email protected]>
e73a768
to
198f15f
Compare
Signed-off-by: Pablo Chacin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking I think we should remove the Binary Provisioning naming from the documentation as much as we can. It is an implementation detail for most of the users. What they care is the fact that they can run extensions directly with the official k6 binary.
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivan <[email protected]>
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Pablo Chacin <[email protected]>
--- | ||
title: 'Run scripts using automatic extension resolution' | ||
description: 'Learn how to run scripts that require extensions.' | ||
weight: 04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move this before custom builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a good idea. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few small comments. What do you think of changing the order of the headings, so it's:
- Before you begin
- Run a test with extensions
- Disable the Automatic Extension Resolution
- Enable community extensions
- Use unsupported extensions
- Limitations
So just moving the main action of running the test to be at the top.
docs/sources/k6/next/extensions/run-extensions-using-automatic-extension-resolution.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-automatic-extension-resolution.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-automatic-extension-resolution.md
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-automatic-extension-resolution.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-automatic-extension-resolution.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-automatic-extension-resolution.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-automatic-extension-resolution.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-automatic-extension-resolution.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-automatic-extension-resolution.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-automatic-extension-resolution.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
What?
Update description of binary provisioning with the enhancements introduced for GA
Checklist
npm start
command locally and verified that the changes look good.docs/sources/k6/next
folder of the documentation.docs/sources/k6/v{most_recent_release}
folder of the documentation.docs/sources/k6/next
folder of the documentation.Related PR(s)/Issue(s)
Closes #1995