-
Notifications
You must be signed in to change notification settings - Fork 238
Add getBy
docs pages
#2023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add getBy
docs pages
#2023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add
{{< code >}}
<!-- md-k6:skip -->
before and
{{< /code >}}
After all the code examples that won't run.
|
||
</TableWithNestedRows> | ||
|
||
### Returns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Returns | |
### Returns |
Is this following the same pattern as other pages? It looks like we could move the headings up for all of these (from h3 to h2, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have this issue in most of the browser docs (maybe elsewhere too) where the heading is one level too low. Would you rather I fix all of them in a new PR?
Just to clarify, we don't need to use the |
Thanks for clarifying! I was wondering whether I needed them or not. When I remove them, then can i still work with EDIT: Yep, those directives still work without the |
...with one language (js or html in a single given example).
What?
This adds docs pages for the following APIs:
Checklist
npm start
command locally and verified that the changes look good.docs/sources/k6/next
folder of the documentation.Related PR(s)/Issue(s)
Check links in description.